Add package.json and (and tsconfig.json) for TS/JS language config roots

[jpaju]

No description provided.

[archseer]

Hmm won't this break package workspaces though? Usually you want the top level package.json/git root there

[jpaju]

Yes, that's probably true. Currently folder structure for monorepos below doesn't work properly since Helix uses folder with .git folder as root:
|-- .git/
|-- service1/
| ---- package.json
|-- service2/
| ---- package.json

Not sure we could make them both (workspaces and structure below) work?

[archseer]

See #5748

[the-mikedavis]

I believe we use the topmost directory with a root marker:

helix/helix-lsp/src/lib.rs

Lines 1009 to 1066 in beb5afc

	/// Find an LSP workspace of a file using the following mechanism:
	/// * if the file is outside `workspace` return `None`
	/// * start at `file` and search the file tree upward
	/// * stop the search at the first `root_dirs` entry that contains `file`
	/// * if no `root_dirs` matches `file` stop at workspace
	/// * Returns the top most directory that contains a `root_marker`
	/// * If no root marker and we stopped at a `root_dirs` entry, return the directory we stopped at
	/// * If we stopped at `workspace` instead and `workspace_is_cwd == false` return `None`
	/// * If we stopped at `workspace` instead and `workspace_is_cwd == true` return `workspace`
	pub fn find_lsp_workspace(
	file: &str,
	root_markers: &[String],
	root_dirs: &[PathBuf],
	workspace: &Path,
	workspace_is_cwd: bool,
	) -> Option<PathBuf> {
	let file = std::path::Path::new(file);
	let mut file = if file.is_absolute() {
	file.to_path_buf()
	} else {
	let current_dir = helix_stdx::env::current_working_dir();
	current_dir.join(file)
	};
	file = path::normalize(&file);
	if !file.starts_with(workspace) {
	return None;
	}
	let mut top_marker = None;
	for ancestor in file.ancestors() {
	if root_markers
	.iter()
	.any(|marker| ancestor.join(marker).exists())
	{
	top_marker = Some(ancestor);
	}
	if root_dirs
	.iter()
	.any(|root_dir| path::normalize(workspace.join(root_dir)) == ancestor)
	{
	// if the worskapce is the cwd do not search any higher for workspaces
	// but specify
	return Some(top_marker.unwrap_or(workspace).to_owned());
	}
	if ancestor == workspace {
	// if the workspace is the CWD, let the LSP decide what the workspace
	// is
	return top_marker
	.or_else(|| (!workspace_is_cwd).then_some(workspace))
	.map(Path::to_owned);
	}
	}
	debug_assert!(false, "workspace must be an ancestor of <file>");
	None
	}

so if we a workspace like

.
+-- package.json
`-- packages
   +-- a
   |   `-- package.json
   `-- b
       `-- package.json

we should use that top-most package.json. I believe we have similar roots set up for Elixir for example with mix.exs or mix.lock that should still work inside umbrella workspaces

[jpaju]

I tried this out and can confirm that the behavior is what @the-mikedavis described! When package.json is specified as roots in languages.toml, Helix reports the correct directory in rootUri/rootPath/workspaceFolders. This applies both to the monorepo folder structure I initially described and to workspace folder structure that @archseer described that has a top-level package.json.