-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme: add adwaita-light theme #10869
Conversation
Can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done with theme inheritance instead? See gruvbox_light
as an example: you can use inherits = "adwaita-dark"
and then overwrite the colors in the palette and any styles that don't match adwaita-dark
@the-mikedavis I think @AbrA-K ended up not sharing colors with |
No I've (mostly) copy&pasted the colors from I'll change it to use inheritance once I have the time - which should be either later today or tomorrow. |
I'm using inheritance now + I saw that it was hard to see when you are in insert mode (the cursor was black in normal&insert mode) so I changed that to a yellow when in insert mode. I hope I didn't miss anything else. |
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: abra <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: abra <[email protected]>
Co-authored-by: Michael Davis <[email protected]> Co-authored-by: abra <[email protected]>
Fixes my Issue #10631.
The colors I used are from the adwaita-dark theme, not from the gtksourceview5 Adwaita theme, because I felt the colors had a better contrast to the background that way. These and other changes where mentioned in my issue (first post) - if you want a more direct analog to the dark theme, I could change this to be more in line with the original.
Lastly, I removed the line with the author of the dark theme. They didn't make adwaita-light, but It's HEAVILY based on that.