Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: add adwaita-light theme #10869

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

AbrA-K
Copy link
Contributor

@AbrA-K AbrA-K commented Jun 2, 2024

Fixes my Issue #10631.
The colors I used are from the adwaita-dark theme, not from the gtksourceview5 Adwaita theme, because I felt the colors had a better contrast to the background that way. These and other changes where mentioned in my issue (first post) - if you want a more direct analog to the dark theme, I could change this to be more in line with the original.

Lastly, I removed the line with the author of the dark theme. They didn't make adwaita-light, but It's HEAVILY based on that.

@kirawi kirawi added the A-theme Area: Theme and appearence related label Jun 15, 2024
@brielov
Copy link

brielov commented Aug 7, 2024

Can we get this merged?

@the-mikedavis the-mikedavis linked an issue Aug 8, 2024 that may be closed by this pull request
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be done with theme inheritance instead? See gruvbox_light as an example: you can use inherits = "adwaita-dark" and then overwrite the colors in the palette and any styles that don't match adwaita-dark

@brielov
Copy link

brielov commented Aug 9, 2024

@the-mikedavis I think @AbrA-K ended up not sharing colors with adwaita-dark but rather using other colors from gtksourceview which would make inheritance rather useless in this case, but I might be mistaken.

@AbrA-K
Copy link
Contributor Author

AbrA-K commented Aug 9, 2024

No I've (mostly) copy&pasted the colors from adwaita-dark.

I'll change it to use inheritance once I have the time - which should be either later today or tomorrow.

@AbrA-K
Copy link
Contributor Author

AbrA-K commented Aug 9, 2024

I'm using inheritance now + I saw that it was hard to see when you are in insert mode (the cursor was black in normal&insert mode) so I changed that to a yellow when in insert mode. I hope I didn't miss anything else.

@the-mikedavis the-mikedavis merged commit 0fca0d0 into helix-editor:master Nov 20, 2024
6 checks passed
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add adwaita light theme
5 participants