Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: :cd with no args changes to home directory #12042

Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat: :cd with no args changes to home directory #12042

merged 2 commits into from
Dec 5, 2024

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Nov 9, 2024

Previously, :cd would error if no arguments was given. This PR makes :cd behave as expected on unix systems, where it changes to home directory if no args are given

arch-il
arch-il approved these changes Nov 10, 2024
View reviewed changes
Copy link

@arch-il arch-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second this change. cd is expected to go to home directory without any arguments. Tested on Windows, works fine.

@kirawi kirawi added the A-command Area: Commands label Nov 26, 2024
the-mikedavis
the-mikedavis approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It might also be nice to add :cd - (cd to the previous directory if there is one). That can be done in a follow-up PR though.

@the-mikedavis the-mikedavis merged commit 565bfbb into helix-editor:master Dec 5, 2024
6 checks passed
@nik-rev nik-rev mentioned this pull request Dec 5, 2024
Merged
GladkihEgor pushed a commit to GladkihEgor/helix that referenced this pull request Jan 4, 2025
@nik-rev @GladkihEgor
feat: :cd with no args changes to home directory (helix-editor#12042)
88681eb
diucicd pushed a commit to diucicd/helix that referenced this pull request Jan 8, 2025
@nik-rev @rongyi
feat: :cd with no args changes to home directory (helix-editor#12042)
f6cf4b3
rmburg pushed a commit to rmburg/helix that referenced this pull request Jan 20, 2025
@nik-rev @rmburg
feat: :cd with no args changes to home directory (helix-editor#12042)
1b88d41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@TornaxO7 TornaxO7 TornaxO7 approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@arch-il arch-il arch-il approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nik-rev @the-mikedavis @TornaxO7 @pascalkuthe @arch-il @kirawi