New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bash completion space regression #12828

Merged

the-mikedavis merged 1 commit into helix-editor:master from xubaiwang:bash-completion

Feb 10, 2025

Contributor

xubaiwang commented Feb 10, 2025

Once fixed in #9708, PR #11246 accidentally introduces a regression that breaks bash completion with space in filename (The IFS=$'\n' is removed).

Instead of setting IFS, this PR uses an alternative mapfile approach, as suggested by ShellCheck SC2207.


          Fix Bash completion space regression

3a91d73

the-mikedavis approved these changes

View reviewed changes

the-mikedavis merged commit ff012e8 into helix-editor:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet