PHP roots and languageserver improvements #2031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request adds two things to the default languages.toml:
Setting the default lsp to intelephense
After a lot of testing of different lsp implementations for php I found intelephense to be the best one for my projects (laravel, TYPO3, Wordpress). The free version offers a lot of value and the professional version is very affordable (15€). I understand that it can be controversial depending on a paid product for full functionality as an open source project, but as a developer I also value tools that save my time.
Defining roots
I added
composer.json
(composer is the de facto standard package manager for PHP) andindex.php
(still the default entry point for all modern projects) as workspace roots.