Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: papercolor-light #3580

Closed
wants to merge 1 commit into from
Closed

lint: papercolor-light #3580

wants to merge 1 commit into from

Conversation

AlexanderBrevig
Copy link
Contributor

passes linter from #3234
image

@AlexanderBrevig
Copy link
Contributor Author

@uncomfyhalomacro please sanity check my choices :)

@uncomfyhalomacro
Copy link
Contributor

@uncomfyhalomacro please sanity check my choices :)

sorry. that really hurts my eyes and I don't really believe that's how papercolor uses those palettes. now thats your sanity check for the day ;)

@uncomfyhalomacro
Copy link
Contributor

Will leave a review after I eat my breakfast in a few :)

@AlexanderBrevig
Copy link
Contributor Author

Thanks! The only change I made is to try and add a cursorline. I don't particularly like that colour and would appreciate a suggestion.

This is how it looks on master:
image

@uncomfyhalomacro
Copy link
Contributor

@AlexanderBrevig I will open a new PR. I just realized I missed some

@uncomfyhalomacro
Copy link
Contributor

See #3585

@AlexanderBrevig
Copy link
Contributor Author

Superseeded by #3585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderBrevig @uncomfyhalomacro