Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix PHPStan #110

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link

From #3

szepeviktor
szepeviktor commented Apr 26, 2023
View reviewed changes
.github/workflows/static-analysis.yml
Comment on lines -53 to -54
- name: Environment Check
run: php -v && composer --version
Copy link
Author

@szepeviktor szepeviktor Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are displayed during shivammathur/setup-php

image

@szepeviktor
Copy link
Author

szepeviktor commented Apr 26, 2023 •
edited
Loading

@mscurtescu CI does not produce errors with WP core functions.

szepeviktor
szepeviktor commented Apr 26, 2023
View reviewed changes
.github/workflows/static-analysis.yml
uses: shivammathur/setup-php@v2
with:
php-version: ${{ env.PHP_VERSION }}
tools: "composer:${{ env.COMPOSER_VERSION }}"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer needs to be installed this early.

@szepeviktor szepeviktor mentioned this pull request Apr 27, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@szepeviktor