Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Bind to a specific IP address #255

Closed
nfam opened this issue Jul 5, 2019 · 2 comments · Fixed by #345
Closed

Feature request: Bind to a specific IP address #255

nfam opened this issue Jul 5, 2019 · 2 comments · Fixed by #345

Comments

@nfam
Copy link

nfam commented Jul 5, 2019

Use case: I have chartmuseum run natively on my laptop (not in docker machine). However, from what I see, chartmuseum listens to all available network interfaces, thus any machine in the same wifi is able to access to my chartmuseum.

Expect: an argument in CLI to specify which network interface, aka. IP, to bind to.
@spigell
Copy link

spigell commented Mar 3, 2020

I need this feature also. +1

@CoolDuke
Copy link

CoolDuke commented Jun 3, 2020

I want chartmuseum to listen on the loopback device to deploy an Nginx in front of it and prohibiting access to chartmuseum directly.

My current workaround is setting up a firewall rule via systemd unit file right before chartmuseum starts:

ExecStartPre=+/bin/bash -c "(iptables -L | grep 8443) || iptables -I INPUT -p tcp --dport 8443 ! -s 127.0.0.1 -j REJECT --reject-with=tcp-reset"
ExecStart=/usr/local/bin/chartmuseum --port 8443 [...]

jayme-github added a commit to jayme-github/chartmuseum that referenced this issue Jun 23, 2020
@jayme-github
Allow to bind chartmuseum to a specific interface
74997b3 
The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind  chartmuseum to a specific interface rather than 0.0.0.0.

Default is 0.0.0.0 to stick with current behaviour.

Fixes helm#255
@jayme-github jayme-github mentioned this issue Jun 23, 2020
Merged
jayme-github added a commit to jayme-github/chartmuseum that referenced this issue Jun 23, 2020
@jayme-github
Allow to bind chartmuseum to a specific interface
bebe72c 
The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind  chartmuseum to a specific interface rather than 0.0.0.0.

Default is 0.0.0.0 to stick with current behaviour.

Fixes helm#255

Signed-off-by: jayme-github <[email protected]>
jayme-github added a commit to jayme-github/chartmuseum that referenced this issue Jun 23, 2020
@jayme-github
Allow to bind chartmuseum to a specific interface
91088c5 
The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind  chartmuseum to a specific interface rather than 0.0.0.0.

Default is 0.0.0.0 to stick with current behaviour.

Fixes helm#255

Signed-off-by: jayme-github <[email protected]>
jdolitsky pushed a commit that referenced this issue Jul 14, 2020
@jayme-github
Allow to bind chartmuseum to a specific interface (#345)
b5bb97f 
* Allow to bind chartmuseum to a specific interface

The new config option "listen.host" ("--listen-host", "LISTEN_HOST") may
be used to bind  chartmuseum to a specific interface rather than 0.0.0.0.

Default is 0.0.0.0 to stick with current behaviour.

Fixes #255

Signed-off-by: jayme-github <[email protected]>

* Refactor to make host a field of router

Signed-off-by: jayme-github <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to bind chartmuseum to a specific interface jayme-github/chartmuseum
3 participants
@CoolDuke @spigell @nfam