Multi architecture container image #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to build a multi-architecture image easily, all architectures should share the same Dockerfile. For this to be possible in a portable way, the `chartmuseum` executable should be built inside a container image. This commit adds a first step to the container image building which is the build of chartmuseum itself. In order to keep the image as small as possible, this is done inside a "builder" image and the produced executable is then copied into the final image. Signed-off-by: Gabriel Duque <[email protected]>
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
Just for the sake of being precise: I have only tested local storage as that is what I use. I have tested it on amd64 and arm64. |
gabriel-duque
force-pushed
the
multi-architecture-container-image
branch
from
515bd22 to
07e07bc
Compare
This commit adds a GitHub action using `docker buildx` to build and push a multi-architecture image to Docker hub. Signed-off-by: Gabriel Duque <[email protected]>
gabriel-duque
force-pushed
the
multi-architecture-container-image
branch
from
07e07bc to
c7c530b
Compare
|
@zuh0 thanks for looking into this, will take a look as soon as possible |
jdolitsky
approved these changes
Jul 14, 2020
|
This is pretty well thought out. I'm going to go ahead and merge. Going to update to use some alt image destination for a week or so to see how it works out before cutting over to chartmuseum/chartmuseum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would allow for a multi-architecture container image to be built and (sometimes) pushed to Docker hub when necessary.
In order for this to work, 2 things were done:
chartmuseumexecutable inside a Docker container in a portable way.docker buildxand "cross-build" the container image for multiple architectures.In order for this to work, 2 secrets need to be added to the
helm/chartmuseumGitHub repository.The first one called DOCKER_USERNAME should be the Docker hub username for the "chartmuseum" account.
The second one called DOCKER_PASSWORD should be an access token generated on Docker hub like explained here.
The images will be built for the following architectures:
The images will be built (and sometimes pushed) in the following circumstances:
chartmuseum/chartmuseum:X.Y.Zandchartmuseum/chartmuseum:latest)chartmuseum/chartmuseum:edgeandchartmuseum/chartmuseum:latest)golangimage and thealpineimage (built and pushed aschartmuseum/chartmuseum:nightlyandchartmuseum/chartmuseum:latest)In order to test this would work, I have built and deployed the multi-architecture image to my own Docker hub account and tested it on the armv8 architecture.
If someone wants to test any other architecture, the image can be found here.
This PR resolves #349 .