-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/rabbitmq] Fix breaking bitnami based RabbitMQ vhost configuration #3363
Conversation
… ability to configure vhosts for bitnami/rabbitmq images
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed the CLA |
/assign @tompizmo |
@novcn: GitHub didn't allow me to assign the following users: tompizmo. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Here's some background: #2853 |
/assign @tompizmor @sameersbn |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: novcn, sameersbn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
…tion (helm#3363) * revert deletion of RABBITMQ_VHOST environment variable to restore the ability to configure vhosts for bitnami/rabbitmq images * bump rabbitmq chart version * removes unused RABBITMQ_DEFAULT_VHOST env variable * bump version to 0.6.17
Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.