Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Switch to golang/dep for dependencies #354

Closed
prydonius opened this issue Sep 14, 2017 · 2 comments
Closed

Switch to golang/dep for dependencies #354

prydonius opened this issue Sep 14, 2017 · 2 comments
Labels
api good first issue size/small

Comments

@prydonius
Copy link
Member

Switch to the official https://github.com/golang/dep tool for dependency management
@prydonius prydonius reopened this Sep 14, 2017
@slintes
Copy link
Contributor

slintes commented Sep 19, 2017

Hi, I want to get familiar with monocular and also with the new dep dependency manager, so I would like to pick up this issue. I see that you use the deis/go-dev docker image for go tooling, currently version v0.22.0, which includes go version 1.7.3.
dep was added in deis/go-dev:v0.24.0, which includes go 1.8.1.
But because dep is still under heavy development, it probably makes sense to even use the latest deis/go-dev:v1.4.0 image, which includes go 1.9.

Long story short: are there reasons to not use go 1.9?

https://github.com/deis/docker-go-dev/releases

@prydonius
Copy link
Member Author

@slintes as discussed on Slack feel free to take this :).

Sorry forgot to answer your question about 1.9, no particular reason, feel free to update to the latest go-dev image!

@slintes slintes mentioned this issue Oct 3, 2017
Merged
prydonius pushed a commit that referenced this issue Oct 4, 2017
@slintes @prydonius
Migrated from glide to dep (#354) (#369)
96812e7 
Notes:
Updated deis/go-dev image version, which includes Go 1.9 and dep
Removed GO15VENDOREXPERIMENT environment variable, it's default since go 1.6
With Go 1.9 there is no need to use something like "glide nv", "./..." does not match vendor directory anymore
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api good first issue size/small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prydonius @slintes