This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Support appVersion field #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 90.4% 90.42% +0.01%
==========================================
Files 18 18
Lines 969 971 +2
==========================================
+ Hits 876 878 +2
Misses 62 62
Partials 31 31
Continue to review full report at Codecov.
|
|
cc @Angelmmiguel @kemcake |
|
Tested 👍 lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the appVersion field from chart metadata.
The appVersion will be shown instead of the chart version in a few prominent places (e.g. chart list view), as this is more useful than the chart version.
This PR also moves to use the github.com/ghodss/yaml library instead of gopkg.in/yaml.v2. This library works better with the Swagger models as it uses the
jsontags on structs which Swagger generates.On the UI side, I modified the chart-details component to fetch the ChartVersion object rather than just pass a string to the children. This made it possible to add the "Application Version" section to the details, and is better as it prevents the child components from having to fetch the version if they need it (e.g. in chart-details-readme).