Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Add support for Traefik as ingress controller #329

Merged
merged 2 commits into from
Jul 25, 2017
Merged

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Jul 25, 2017

This adds support for Traefik as an Ingress controller

To use it simply comment the nginx annotations and uncomment the traefik annotations.

Tested with Traefik 1.3.3

Miouge1 and others added 2 commits July 25, 2017 15:08
This adds support for Traefik as an Ingress controller.
@prydonius
Copy link
Member

Thanks @Miouge1! Do you want this to be released as a new chart version? I'm not sure it makes sense since this is just updating documentation, but if you feel it should then bump the version in Chart.yaml.

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          15       15           
  Lines         618      618           
=======================================
  Hits          550      550           
  Misses         45       45           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5b3cd...ff0de7e. Read the comment docs.

@Miouge1
Copy link
Contributor Author

Miouge1 commented Jul 25, 2017

Agreed, I don't think a new version number is necessary either

@prydonius
Copy link
Member

Ok, in that case I'll merge as-is. Thanks again!

@prydonius prydonius merged commit 94618a9 into helm:master Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants