This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Add search endpoint #609
Merged
Add search endpoint #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Martinez Gotor <[email protected]>
prydonius
approved these changes
Mar 7, 2019
| if params["repo"] != "" { | ||
| conditions["repo.name"] = params["repo"] | ||
| } | ||
| if err := db.C(chartCollection).Find(conditions).All(&charts); err != nil { |
There was a problem hiding this comment.
So if there are no matches MongoDB returns an error? Doesn't it just return an empty list with no error?
There was a problem hiding this comment.
it doesn't return an error, it logs that the query didn't return any chart and it returns an empty list
|
Looks like this PR is based on #605 as it's looking for
|
cpoole
pushed a commit
to cpoole/monocular
that referenced
this pull request
Mar 7, 2019
circle build helm#609
* chartsvc: add support for pagination Signed-off-by: Andres Martinez Gotor <[email protected]> * Apply review changes. Pre-filter unique charts Signed-off-by: Andres Martinez Gotor <[email protected]> * Update kubeapps/common dep Signed-off-by: Andres Martinez Gotor <[email protected]> * Use aggregation to query unique charts. Apply other review comments Signed-off-by: Andres Martinez Gotor <[email protected]> * Count using the pipeline Signed-off-by: Andres Martinez Gotor <[email protected]> * Update common dep. Minor review Signed-off-by: Andres Martinez Gotor <[email protected]>
* Signed-off-by: Himanshu Pandey <[email protected]> Added check for empty charts * Added Test case for Empty Charts Signed-off-by: Himanshu Pandey <[email protected]> * Corrected the test case Signed-off-by: Himanshu Pandey <[email protected]>
Signed-off-by: Andres Martinez Gotor <[email protected]>
Yes, I have rebased master now that that PR is merged. |
Signed-off-by: Andres Martinez Gotor <[email protected]>
Signed-off-by: Andres Martinez Gotor <[email protected]>
|
Merging this. Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #605
This PR adds a
/searchendpoint to the chartsvc to mimic the same behavior that monocular does in the client side:https://github.com/helm/monocular/blob/master/frontend/src/app/shared/services/charts.service.ts#L75
I have tested the changes manually but since the function is mostly a mongodb query there is nothing valuable that we can add as unit tests.