Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI (clippy) #275

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix CI (clippy) #275

merged 6 commits into from
Dec 10, 2024

Conversation

vsiles
Copy link
Contributor

@vsiles vsiles commented Dec 10, 2024

While working on another MR, clippy complained about these. Fixing main.
Most notable change: Bumping human-panic to major version 2 to avoid a deprecation warning

@vsiles
Copy link
Contributor Author

vsiles commented Dec 10, 2024

Seems like human-panic v2 is a no go at the moment because of CI step deny.
Are we happy with a [allow(deprecation)] and revert back to v1 ? Please advise.

@mara-schulke
Copy link
Contributor

Im happy with just bumping here aswell!

@vsiles vsiles merged commit e4c0c77 into main Dec 10, 2024
7 checks passed
@vsiles vsiles deleted the vsiles/fix-clippy branch December 10, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants