-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add terminal color check #184
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying kyanos with Cloudflare Pages
|
func Is256ColorSupported() bool { | ||
term := os.Getenv("TERM") | ||
return strings.Contains(term, "256color") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but this check is way too naive
Take a look at project that could help you to detect that capabilities
https://pkg.go.dev/github.com/gookit/color#IsSupport256Color
The simplest would be to use this
https://pkg.go.dev/github.com/muesli/termenv#DefaultOutput
Then call ColorProfile
https://pkg.go.dev/github.com/muesli/termenv#Output.ColorProfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing out the issues! I'll modify this part of the code later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add terminal color check