Fix GitHub.com access issues in mainland China & Add checksum support #290
+128
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `-c` flag to use GitHub mirror (ghp.ci) for mainland China users - Implement checksum verification for downloaded files - Add progress bar for file downloads This change improves installation reliability and user experience, especially for users in regions (China mainland etc.) with limited GitHub access.
|
Thank you, I was not aware of those problems. Your changes sound great! I saw this PR right as I'm about to go to sleep, but I'll follow up tomorrow. Also, in the web UI we can add the |
|
Merged, thanks 👍 |
|
But "ghp.ci" doesn't seem to be accessible in mainland China anymore. |
|
@ImYrS It looks like it's back up. Hopefully a temporary problem. If it still doesn't work, try without the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users in mainland China frequently encounter issues when installing beszel-agent:
Solution
This commit adds support for GitHub mirrors to resolve network issues:
--china-mirrorsflag to use ghp.ci mirror for reliable downloadsUsage
# Install using China-friendly mirror ./install-agent.sh --china-mirrors ...Additional Notes
The ghp.ci mirror is widely used in China and provides reliable access to GitHub resources. This solution follows similar patterns used by other popular open-source projects to support users in mainland China.
Thank you for taking the time to review this PR!
If you feel that this improvement would be helpful to the community, please feel free to discuss it with me. I'm also happy to make changes based on your suggestions to ensure code quality and user experience.