Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Auth token not passed in gRPC calls #78

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix Auth token not passed in gRPC calls #78

merged 1 commit into from
Dec 19, 2023

Conversation

aminalaee
Copy link
Contributor

Fixes #73

All methods, except authenticate methods, should pass Auth token using the options call, this PR will add that to the methods missing this.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@obrunsmann obrunsmann changed the base branch from main to develop December 19, 2023 08:25
obrunsmann
obrunsmann approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@obrunsmann obrunsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aminalaee - and perfect use of the formatting standards 💪

@obrunsmann obrunsmann merged commit 01ba52a into heroiclabs:develop Dec 19, 2023
1 check passed
@aminalaee aminalaee deleted the add-missing-auth-to-grpc-calls branch December 20, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrunsmann obrunsmann obrunsmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication issues
3 participants
@aminalaee @CLAassistant @obrunsmann