Improve tests for buildpack env var handling #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Shifts the testing of buildpack env vars handling slightly more towards integration tests rather than unit tests, since a big part of env var handling is ensuring the env is passed around correctly + aspects like the automatic env vars added by libcnb and lifecycle, which can only be properly tested via integration tests. * Adds more testing of broken user-provided env vars, by passing them in by default for all tests (instead of a single test), and by adding more broken env vars to the list. * In the unit tests, switches the example layer location to one that's more obviously an example path, to prevent anyone reading the tests from thinking that's the actual location set by the buildpack. This change will help validate the env var handling remains consistent with the upcoming transition to libcnb.rs' struct layer API. GUS-W-16261336.
edmorley
force-pushed
the
cleanup-env-var-tests
branch
from
8944edd to
2187a90
Compare
joshwlewis
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will help validate the env var handling remains consistent with the upcoming transition to libcnb.rs' struct layer API.
GUS-W-16261336.