Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libcnb tracing #320

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Enable libcnb tracing #320

merged 1 commit into from
Jan 23, 2025

Conversation

edmorley
Copy link
Member

This enables libcnb's trace feature, which means traces, spans, and events are written to OpenTelemetry export files on disk in the ephemeral build container, which can then be read by the Heroku build system or when debugging locally with Pack (so long as a suitable --volume mount has been configured).

See:
heroku/libcnb.rs#723

GUS-W-15148605.

This enables `libcnb`'s `trace` feature, which means traces, spans, and
events are written to OpenTelemetry export files on disk in the ephemeral
build container, which can then be read by the Heroku build system or
when debugging locally with Pack (so long as a suitable `--volume` mount
has been configured).

See:
heroku/libcnb.rs#723

GUS-W-15148605.
@edmorley edmorley self-assigned this Jan 23, 2025
@edmorley edmorley marked this pull request as ready for review January 23, 2025 13:00
edmorley added a commit that referenced this pull request Jan 23, 2025
GitHub recently announced ARM support when using their
public runners:
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

This means we don't need to use the custom runner group
for ARM CI jobs any more, which have a slower boot time,
since they don't have a warm slack pool of machines.

For example the CI run in #320 has been waiting for 11 mins
for a runner to be available:

```
Waiting for a runner to pick up this job...
```
edmorley added a commit that referenced this pull request Jan 23, 2025
GitHub recently announced ARM support when using their
public runners:
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/

This means we don't need to use the custom runner group
for ARM CI jobs any more, which have a slower boot time,
since they don't have a warm slack pool of machines.

For example the CI run in #320 has been waiting for 11 mins
for a runner to be available:

```
Waiting for a runner to pick up this job...
```

GUS-W-17659818.
@edmorley edmorley merged commit 1bb68e5 into main Jan 23, 2025
7 checks passed
@edmorley edmorley deleted the enable-libcnb-tracing branch January 23, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants