Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addons): add inference disclaimer #3076

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

zwhitfield3
Copy link
Contributor

Description

Work Item

This PR adds a disclaimer when creating inference models using heroku addons:create

Testing

  1. Pull down branch & yarn it up
  2. Confirm disclaimer is present when creating an inference model instance via ./bin/run addons:create heroku-inference-staging:claude-3-5-sonnet -a heroku-cli-test-staging
  3. Destroy addon for clean up via ./bin/run addons:destroy <INFERENCE_MODEL_ID> -a heroku-cli-test-staging

Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, but overall it looks great, so I'm approving.

packages/cli/src/commands/addons/create.ts Outdated Show resolved Hide resolved
Co-authored-by: Santiago Bosio <[email protected]>
@zwhitfield3 zwhitfield3 merged commit 6d33a56 into main Nov 12, 2024
8 checks passed
@zwhitfield3 zwhitfield3 deleted the zw/addons-ai-disclaimer branch November 12, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants