Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bin/report script to capture buildpack metadata #110

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Add bin/report script to capture buildpack metadata #110

merged 5 commits into from
Mar 1, 2024

Conversation

colincasey
Copy link
Contributor

Captures buildpack information including:

  • packages requested
  • custom Debian urls requested
  • custom repositories requested

W-15039947

@colincasey colincasey requested a review from a team as a code owner February 15, 2024 18:20
@colincasey colincasey self-assigned this Feb 15, 2024
@edmorley edmorley removed the request for review from a team February 19, 2024 16:34
@edmorley
Copy link
Member

edmorley commented Feb 19, 2024 •
edited
Loading

Switching review to @dzuelke to balance review load and for David's bash/apt expertise :-)

@edmorley edmorley requested a review from dzuelke February 19, 2024 16:35
dzuelke
dzuelke requested changes Feb 20, 2024
View reviewed changes
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
bin/report Outdated Show resolved Hide resolved
@colincasey colincasey requested a review from dzuelke February 20, 2024 21:15
dzuelke
dzuelke requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@dzuelke dzuelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing about that extra if in the loop and its resulting many grep invocations :)

bin/report Outdated Show resolved Hide resolved
@colincasey colincasey requested a review from dzuelke February 29, 2024 18:00
dzuelke
dzuelke approved these changes Feb 29, 2024
View reviewed changes
bin/report Outdated Show resolved Hide resolved
@colincasey colincasey merged commit 9d62480 into master Mar 1, 2024
1 check passed
@colincasey colincasey deleted the add_metrics branch March 1, 2024 14:18
@colincasey colincasey mentioned this pull request Mar 1, 2024
Merged
colincasey added a commit that referenced this pull request Mar 1, 2024
@colincasey
Prepare release v7
55f2445 
Includes:
- #110
@edmorley
Copy link
Member

edmorley commented Mar 1, 2024

Data in Honeycomb looks good :-)

https://ui.honeycomb.io/heroku/datasets/builds/result/3erMEVgZXGL?tab=events

colincasey added a commit that referenced this pull request Mar 1, 2024
@colincasey
Prepare release v7 (#111)
00fa95b 
Includes:
- #110
Frzk pushed a commit to Scalingo/apt-buildpack that referenced this pull request May 13, 2024
@colincasey @Frzk
Add bin/report script to capture buildpack metadata (heroku#110)
31acd20 
* Add `bin/report` script to capture buildpack metadata

[W-15039947](https://gus.lightning.force.com/lightning/r/a07EE00001k7v4BYAQ/view)
Frzk pushed a commit to Scalingo/apt-buildpack that referenced this pull request May 13, 2024
@colincasey @Frzk
Prepare release v7 (heroku#111)
5349c46 
Includes:
- heroku#110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzuelke dzuelke dzuelke approved these changes

Assignees

@colincasey colincasey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colincasey @edmorley @dzuelke