Adding support for comments in Aptfiles. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be super helpful! |
renanlecaro
reviewed
Feb 13, 2018
| @@ -20,8 +20,11 @@ heroku buildpacks:add --index 1 https://github.com/heroku/heroku-buildpack-apt | |||
|
|
|||
| #### Aptfile | |||
|
|
|||
| # you can list packages | |||
There was a problem hiding this comment.
This really needs to be in the readme, i was wondering what all those 3 lines where all about, i thought it was just one package being described in some weird way
|
This PR would address this open issue: #34. |
|
I've added a test. The Travis failure is due to #16 and is also present on |
edmorley
approved these changes
Jun 10, 2019
|
Thanks, @edmorley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix allows you to include comments in your
Aptfile.It also helps make the README more readable.