Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable devDependency pruning for Yarn 2 #1001

Merged
merged 4 commits into from
May 26, 2022

Conversation

colincasey
Copy link
Contributor

After monitoring the custom Yarn 2 plugin for a period of time there doesn't seem to be any issues from the 20% of builds that it has been active on. This PR enables this feature completely and removes the old code path that used to handle pruning for Yarn 2.

See #999, GUS-W-9502576

After monitoring the custom Yarn 2 plugin for a period of time there doesn't seem to be any issues from the 20% of builds that it has been active on.  This PR enables this feature completely and removes the old code path that used to handle pruning for Yarn 2.
@colincasey colincasey requested a review from a team as a code owner May 18, 2022 14:28
@colincasey
Copy link
Contributor Author

@edmorley the ignores added in this PR should address your comment from #999. Thanks for letting me know about that 😄

@edmorley
Copy link
Member

Awesome - thank you! :-)

After monitoring the custom Yarn 2 plugin for a period of time there doesn't seem to be any issues from the 20% of builds that it has been active on.  This PR enables this feature completely and removes the old code path that used to handle pruning for Yarn 2.
@colincasey colincasey enabled auto-merge May 26, 2022 16:06
@colincasey colincasey merged commit e496d9c into main May 26, 2022
@colincasey colincasey deleted the ccasey/fully_enable_yarn2_pruning branch May 26, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants