Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis badge to use master #753

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

danielleadams
Copy link
Contributor

No description provided.

@danielleadams danielleadams requested a review from a team as a code owner April 2, 2020 13:44
@danielleadams danielleadams merged commit 08e52c2 into master Apr 2, 2020
@danielleadams danielleadams deleted the danielleadams-patch-1 branch April 2, 2020 14:48
@edmorley
Copy link
Member

edmorley commented Sep 17, 2020

@danielleadams Hi! I followed a source link from another repo earlier and ended up looking at the master branch version of a file in this repo rather than main - which will progressively get more out of date over time.

Would it be possible to delete the master branch, so that GitHub's web UI redirects work and so existing links still point at the latest content?

This would break builds that hardcode master in the buildpack URL, however for this buildpack there are only 3 such apps - with last deploy dates of 2017-05, 2018-03 and 2019-02 respectively:
https://heroku.slack.com/archives/C1RU92Y1L/p1596575218489500?thread_ts=1596479766.483800&cid=C1RU92Y1L

...so this seems pretty safe to do.

@danielleadams
Copy link
Contributor Author

Done 👍 where was the source link from?

@edmorley
Copy link
Member

Thank you :-)

It was from heroku/buildpack-stdlib#43 (I'm reading up on bin/report for adding it to Python in the future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants