Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add spec support for Node 13 and 14 #766

Merged
merged 2 commits into from
Apr 27, 2020
Merged

add spec support for Node 13 and 14 #766

merged 2 commits into from
Apr 27, 2020

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Apr 23, 2020 •
edited
Loading

Includes

  • repo fixtures for Node 14
  • add Node 13 and 14 specs

@danielleadams danielleadams requested a review from a team as a code owner April 23, 2020 17:52
@danielleadams danielleadams changed the base branch from master to da/add-node-14-plugins April 24, 2020 18:13
@danielleadams danielleadams removed the WIP label Apr 24, 2020
Malax
Malax reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also adds specs for Node 13. If that is intentional, we should add it to the CHANGELOG as well.

@danielleadams danielleadams changed the title add spec support for Node 14 add spec support for Node 13 and 14 Apr 27, 2020
@danielleadams
Copy link
Contributor Author

@Malax updated all the commits and CHANGELOG.. thanks!

@danielleadams danielleadams changed the base branch from da/add-node-14-plugins to master April 27, 2020 13:04
@danielleadams danielleadams merged commit ad3cc08 into master Apr 27, 2020
@danielleadams danielleadams deleted the node-14-tests branch April 27, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malax Malax Malax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielleadams @Malax