Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if http_proxy/https_proxy set and no_proxy is not aws #782

Merged
merged 4 commits into from
May 13, 2020
Merged

warn if http_proxy/https_proxy set and no_proxy is not aws #782

merged 4 commits into from
May 13, 2020

Conversation

lillianzhang331
Copy link
Contributor

User should be warned of build failure if NO_PROXY is not set to "amazonaws.com" when HTTP_PROXY or HTTPS_PROXY is set. See AWS proxy error section.

@lillianzhang331 lillianzhang331 requested a review from a team as a code owner May 11, 2020 22:23
danielleadams
danielleadams reviewed May 12, 2020
View reviewed changes
lib/failure.sh Outdated Show resolved Hide resolved
danielleadams
danielleadams suggested changes May 12, 2020
View reviewed changes
lib/failure.sh Outdated Show resolved Hide resolved
test/run Show resolved Hide resolved
danielleadams
danielleadams approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@danielleadams danielleadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lillianzhang331 lillianzhang331 merged commit 50e73aa into master May 13, 2020
@lillianzhang331 lillianzhang331 deleted the warn-proxy branch May 13, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lillianzhang331 @danielleadams