Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use meta_get to get package manager name #802

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Jul 9, 2020

It seems that the all package managers are being reported as npm, so the if statement here is not true: https://github.com/heroku/heroku-buildpack-nodejs/blob/master/bin/report#L107, and the reporting is wrong.

This pull request creates a method in lib/dependencies.sh to use in both bin/compile and bin/report to detect for a yarn.lock file (and subsequently use Yarn logic).

@danielleadams danielleadams requested a review from a team as a code owner July 9, 2020 16:47
@danielleadams danielleadams force-pushed the fix-bin/report-package-manager-reporting branch from b1fbee0 to c26d853 Compare July 9, 2020 17:46
@danielleadams danielleadams changed the title add an export for YARN create has_yarn_lock_file method Jul 9, 2020
@danielleadams danielleadams force-pushed the fix-bin/report-package-manager-reporting branch from c26d853 to 433a111 Compare July 9, 2020 18:21
@danielleadams danielleadams changed the title create has_yarn_lock_file method use meta_get to get package manager name Jul 10, 2020
@danielleadams danielleadams force-pushed the fix-bin/report-package-manager-reporting branch from 32406af to 2f97823 Compare July 10, 2020 15:21
@danielleadams danielleadams merged commit 3209e60 into master Jul 10, 2020
@danielleadams danielleadams deleted the fix-bin/report-package-manager-reporting branch July 10, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants