Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create hatchet tests to be shared across languages #833

Merged
merged 7 commits into from
Aug 24, 2020
Merged

Create hatchet tests to be shared across languages #833

merged 7 commits into from
Aug 24, 2020

Conversation

lillianzhang331
Copy link
Contributor

  • Test that builds fail when a bad version is specified
  • Test cache for regular deploys is used on repeated deploys
  • Test modifying a requirement clears the cache appropriately
  • Test deploying the getting started guide works
  • Test that all paths set by the buildpack are absolute instead of relative
  • Test upgrading stack invalidates the cache
  • Test CI deploys run tests and use the cache

@lillianzhang331 lillianzhang331 requested a review from a team as a code owner August 19, 2020 18:24
schneems
schneems reviewed Aug 19, 2020
View reviewed changes
hatchet.json Outdated Show resolved Hide resolved
schneems
schneems requested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@schneems schneems left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see spec/fixtures/badNodeVersion being used anywhere. I think we can delete it.

I double-checked and it looks like we're covering all the test cases. If we delete that folder, address the extra comments, and change the absolute path spec to use :default instead of the env var, then I think this is good to go. Thanks for working on this!

spec/hatchet/ci_spec.rb Outdated Show resolved Hide resolved
spec/hatchet/absolute_path_spec.rb Outdated Show resolved Hide resolved
schneems
schneems approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@mlavina mlavina mentioned this pull request Aug 24, 2020
Closed
@lillianzhang331 lillianzhang331 merged commit 59ea2be into main Aug 24, 2020
@lillianzhang331 lillianzhang331 deleted the shared-hatchet-tests branch August 24, 2020 17:40
@lillianzhang331 lillianzhang331 restored the shared-hatchet-tests branch August 24, 2020 17:54
@lillianzhang331 lillianzhang331 deleted the shared-hatchet-tests branch August 24, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneems schneems schneems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lillianzhang331 @schneems