fix return value for detecting yarn workspace plugin #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielleadams
force-pushed
the
bug/fix-yarn-prune
branch
from
8994176
to
2935101
Compare
sargunv
reviewed
Feb 26, 2021
lib/yarn-2.sh
Outdated
| path="" | ||
| fi | ||
|
|
||
| [[ ! "$path" == "" ]] |
There was a problem hiding this comment.
I'd recommend instead querying Yarn directly to see if the plugin is installed, to guard against potential changes in config format or location. Also use the full name @yarnpkg/plugin-workspace-tools to guard against potential third party plugins with a similar name but different behavior.
Something like:
yarn plugin runtime | grep '@yarnpkg/plugin-workspace-tools'
|
@sargunv went ahead and made the recommended change. Didn't realize that was available. Thanks! |
edmorley
approved these changes
Feb 26, 2021
|
Awesome, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #904