-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry Feature #807
Poetry Feature #807
Conversation
@@ -15,8 +15,8 @@ | |||
BUILD_DIR=$1 | |||
|
|||
# Exit early if app is clearly not Python. | |||
if [ ! -f "$BUILD_DIR/requirements.txt" ] && [ ! -f "$BUILD_DIR/setup.py" ] && [ ! -f "$BUILD_DIR/Pipfile" ]; then | |||
if [ -f "$BUILD_DIR/requirements.txt" ] || [ -f "$BUILD_DIR/setup.py" ] || [ -f "$BUILD_DIR/Pipfile" ] || [ -f "$BUILD_DIR/Pipfile.lock"] || [ -f "$BUILD_DIR/pyproject.py"] || [ -f "$BUILD_DIR/poetry.lock"]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: pyproject.py → pyproject.toml
Hey @AndreGuerra123, finally got around to testing your build pack up on heroku. Turns out it doesn't really work, this is the output of a poetry init'd application:
I'll go through your code, check what's going on and drop a review so you can fix it. |
Hi @AndreGuerra123 ! Thanks for the pr! ❤️ 🌮 ❤️ I appreciate the time you've spent here. There have been several different poetry support prs, and after reviewing them all, #835's implementation is the one I'll be moving forward with. The good news is that this functionality should be coming soon 👍thank you for your contributions! |
Hi,
This is a pull request for Poetry suporte. All tests passed. I simply cannot squash the commits I had done during testing. Hope some git guru could find a way to do it.
Best regards,
Andre
PS: Change.log and Docs should be updated after this since I have not run it throw the CI yet.