Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #1202] Add support for Rails 7 & jsbundling #1212

Merged
merged 2 commits into from
Oct 19, 2021

Commits on Oct 13, 2021

  1. [close #1202] Add support for Rails 7 & jsbundling

    Rails 7 introduced the gem:
    
    ```
    gem "jsbundling-rails", "~> 0.1.0"
    ```
    
    Which no longer relies on `webpacker`. 
    
    Issue #1202 was opened since developers using jsbundling would expect `yarn` to be available but won't have the `webpacker` gem which we use to gate detection for yarn installation.
    
    With this change we now install nodejs when a `package.json` is detected and yarn when `yarn.lock` is detected.
    schneems committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    1efd315 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. [close #1202] Add support for Rails 7 & jsbundling

    Rails 7 introduced the gem:
    
    ```
    gem "jsbundling-rails", "~> 0.1.0"
    ```
    
    Which no longer relies on `webpacker`. 
    
    Issue #1202 was opened since developers using jsbundling would expect `yarn` to be available but won't have the `webpacker` gem which we use to gate detection for yarn installation.
    
    With this change we now install nodejs when a `package.json` is detected and yarn when `yarn.lock` is detected.
    schneems committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    61361a0 View commit details
    Browse the repository at this point in the history