Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize Rails7 Database setup on Heroku CI #1257

Merged
merged 3 commits into from
Jan 4, 2022

Commits on Jan 4, 2022

  1. Test Rails 7 app against Heroku CI

    Added a test for Rails 7 to exercise behavior in #1254. Update the Rails 7 example app to use the released version instead of alpha. Also update the app to be Heroku CI compat app (adds app.json):
    
    - sharpstone/rails-jsbundling@34bd25c
    - sharpstone/rails-jsbundling@a98a4e4
    - sharpstone/rails-jsbundling@b4ec664
    - sharpstone/rails-jsbundling@1fb48b4
    
    Add CI tests against Rails 7
    schneems committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    b2b6a99 View commit details
    Browse the repository at this point in the history
  2. Specialize Rails7 Database setup

    In Rails 6.1 the tasks used for database setup in our test pack were deprecated. They were removed in Rails 7 https://edgeguides.rubyonrails.org/7_0_release_notes.html.
    
    This commit moves to specialize the tasks for Rails7+ to use `db:schema:load` per deprecation instruction:
    
    ```
    DEPRECATION WARNING: Using `bin/rails db:schema:load_if_ruby` is deprecated and will be removed in Rails 7.0. Configure the format using `config.active_record.schema_format = :ruby` to use `schema.rb` and run `bin/rails db:schema:load` instead. (called from <main> at /app/bin/rake:4)
    ```
    schneems committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    5cd2c55 View commit details
    Browse the repository at this point in the history
  3. v236

    schneems committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1c518d7 View commit details
    Browse the repository at this point in the history