Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorize buildpack failures #788

Merged
merged 4 commits into from
Jul 5, 2018
Merged

Colorize buildpack failures #788

merged 4 commits into from
Jul 5, 2018

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Jul 3, 2018 •
edited
Loading

Example output for Errors:

Example output for Warnings:

@schneems schneems force-pushed the schneems/red-failure branch 12 times, most recently from 891a6e5 to 3e5669e Compare July 3, 2018 14:56
sigmavirus24
sigmavirus24 approved these changes Jul 3, 2018
View reviewed changes
Copy link

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits, otherwise LGTM

lib/language_pack/base.rb Outdated
@@ -91,6 +91,7 @@ def compile
topic "DEPRECATIONS:"
puts @deprecations.join("\n")
end
Kernel.puts "\e[0m"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a comment to indicate this is "default"?

lib/language_pack/shell_helpers.rb
e.message.split("\n").each do |line|
Kernel.puts " ! #{line.strip}"
end
Kernel.puts " !\e[0m"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here

@schneems
Copy link
Contributor Author

schneems commented Jul 3, 2018

Worth mentioning that I tested this on windows 8 and it works
2018-07-03 12 51 13
2018-07-03 12 48 20

@schneems
Copy link
Contributor Author

schneems commented Jul 4, 2018

Changed to make warnings not so overbearing

@schneems schneems merged commit f16fbb6 into master Jul 5, 2018
@dmathieu dmathieu deleted the schneems/red-failure branch July 5, 2018 14:47
@schneems
Copy link
Contributor Author

schneems commented Jul 6, 2018

@dmathieu is there a reason you deleted the branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@dzuelke dzuelke dzuelke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schneems @dzuelke @sigmavirus24