This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Makes config copying idempotent #70
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we have following paths: /bin/ # directory /scripts/config/my/con/fig.conf When we are copying directory via `cp -a foo/script/config /bin/config` We get new file with following path: /bin/config/my/con/fig.conf But if we run that script again when '/bin/config/` is already present we would get another file with path: /bin/config/config/my/con/fig.conf This commit makes second and consecutive runs of script overwrite same file
|
Thanks, looks good to me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use few features that not yet merged to master So I fork this buildpack, merge required changes and have following config on heroku:
As emberjs includes
staticbuildpack in my setup I'm running this buildpack twice.Expected behaviour:
nginx.conf.erbfrom latter version ofheroku-buildpack-staticoverrides former one, w/o affecting binaries.Actual behaviour
two different
nginx.conf.erbis created:~/bin/config/templates/nginx.conf.erb~/bin/config/config/templates/nginx.conf.erbI have explanation why that is happening in commit message.