This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Adds cleardb addon support, closing issue #126 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're hardcoding the password anyway, would it make sense to just set |
|
Modified |
|
I'd love to get this pulled in - mysql support is a must for us |
|
Looks good, pulling this in. Thanks! |
friism
added a commit
that referenced
this pull request
Oct 14, 2015
Adds cleardb addon support, closing issue #126
|
Thanks, but you should pull in #129 too to make this work |
jgkim
added a commit
to jgkim/heroku-container-tools
that referenced
this pull request
Dec 3, 2015
jgkim
added a commit
to jgkim/heroku-container-tools
that referenced
this pull request
May 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cleardb addon support, but is blocked by PR #129 for MySQL env var support. This fixes issue #126. Tested locally and on Heroku, works nice.