Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

rest_client not required if using Client without CLI #1201

Closed
danielmorrison opened this issue Sep 3, 2014 · 2 comments · Fixed by #1202
Closed

rest_client not required if using Client without CLI #1201

danielmorrison opened this issue Sep 3, 2014 · 2 comments · Fixed by #1202

Comments

@danielmorrison
Copy link
Contributor

In 89293ef require 'rest_client' was moved out of many classes and into cli.rb.

Unfortunately, if you try to use Heroku::Client without the Heroku::CLI (which is what kjohnston/pgbackups-archive does) you get an error that RestClient hasn't been required:

NameError: uninitialized constant Heroku::Client::Pgbackups::RestClient
    from /app/vendor/bundle/ruby/2.1.0/gems/heroku-3.10.3/lib/heroku/client/pgbackups.rb:14:in `authenticated_resource'

It seems like Heroku::Client should also require 'rest_client'. I'm happy to whip up a PR for that, but wanted to see if there's a better solution first.

Cheers!

@jdx
Copy link
Contributor

jdx commented Sep 3, 2014

that sounds like a good solution

@jdx
Copy link
Contributor

jdx commented Sep 3, 2014

removing that require fixed a bunch of problems, so we definitely want to keep the commit

danielmorrison added a commit to danielmorrison/heroku that referenced this issue Sep 3, 2014
Fixes heroku#1201

RestClient is not available if you use Client directly without CLI/
@jdx jdx closed this as completed in #1202 Sep 3, 2014
AsherBond pushed a commit to AsherBond/heroku that referenced this issue Jan 19, 2024
Fixes heroku#1201

RestClient is not available if you use Client directly without CLI/
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants