This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
prevent uploading to beta releases older than the current release #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this might be a bad idea. It appears old rubygems versions will fail https://rails.lighthouseapp.com/projects/8994/tickets/2880-malformed-version-number-string-30pre happened to me... might have to look for an alternative solution |
|
damn! never ceases to amaze how even the most trivial things can be broken in some context, heh. |
|
So this is actually a non-issue I think (at least part of it) I think I was just using the pre version wrong, it's supposed to be something like 3.9.6.pre1 not 3.9.6.pre I'll test to make sure it works that way. Ensuring beta releases don't downgrade is important, however. So I'll probably change this PR to just include that. |
jdx
changed the title
|
updating to just include the changes for preventing updating to an older release |
added 2 commits
August 15, 2014 14:00
This conversion is done by Transpec 2.3.6 with the following command:
transpec
* 19 conversions
from: == expected
to: eq(expected)
* 19 conversions
from: obj.should
to: expect(obj).to
* 2 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: obj.stub(:message => value)
to: allow(obj).to receive_messages(:message => value)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
jdx
pushed a commit
that referenced
this pull request
Aug 15, 2014
prevent uploading to beta releases older than the current release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are 2 minor bugs with beta releases. First, the updater currently thinks that beta releases are newer than the released version.
In other words, that
3.9.6-preis newer than3.9.6. That was resolved by adding the semantic gem to do the actual calculations.Another bug was that it would update to the newest beta release. Now it will abort if it is about to install something older than the current release.