This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
removed lazy-requiring of rest-client and heroku-api #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
pushed a commit
that referenced
this pull request
Aug 20, 2014
removed lazy-requiring of rest-client and heroku-api
|
Yeees 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are causing issues where we can't see the real error as it crashes trying to catch a RestClient error that hasn't been loaded. There is a technique in place to prevent that, but it's obviously not working.
Also,
heroku-apiisn't even lazy loaded. We can revisit the lazy loading later, but we need to stop these errors from being swallowed.