Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Support for paranoid operations on commands using RestClient #1204

Merged
merged 1 commit into from
Sep 10, 2014

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Sep 10, 2014

Paranoid currently only works in Excon. This adds support to
RestClient as well, so that we can use things like heroku logs.

/cc @deafbybeheading @pedro

Paranoid currently only works in Excon. This adds support to
`RestClient` as well.
@jdx
Copy link
Contributor

jdx commented Sep 10, 2014

looks good to me, although it would be nice if the same exceptions were raised from RestClient

@brandur
Copy link
Contributor Author

brandur commented Sep 10, 2014

@dickeyxxx +1. It's possible though that the effort involved there might be similar to that of just eliminating the use of RestClient completely.

jdx pushed a commit that referenced this pull request Sep 10, 2014
…port

Support for paranoid operations on commands using `RestClient`
@jdx jdx merged commit 460b655 into master Sep 10, 2014
@jdx jdx deleted the brandur-rest-client-paranoid-support branch September 10, 2014 18:30
@jdx
Copy link
Contributor

jdx commented Sep 10, 2014

that's a good point

@jdx
Copy link
Contributor

jdx commented Sep 10, 2014

want me to push out a release with this?

@msakrejda
Copy link
Contributor

You're doing the FSM's work, @brandur.

@hgmnz
Copy link
Contributor

hgmnz commented Sep 10, 2014

Thanks @brandur!

On Wed, Sep 10, 2014 at 11:34 AM, Maciek Sakrejda [email protected]
wrote:

You're doing the FSM's work, @brandur https://github.com/brandur.


Reply to this email directly or view it on GitHub
#1204 (comment).

@brandur
Copy link
Contributor Author

brandur commented Sep 10, 2014

Hah, thanks guys!

@dickeyxxx heroku logs is broken for paranoid apps right now. I'd say that since Maciek is the first person to notice, the release isn't critical, but it would be nice to see it sooner rather than later. Thanks for offering!

@msakrejda
Copy link
Contributor

@dickeyxxx @brandur yeah, I'm not in a huge hurry here--preauth is a tolerable workaround.

@pedro
Copy link
Contributor

pedro commented Sep 10, 2014

Nice dude 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants