Show backups that will be migrated from PGBackups

[msakrejda]

This cleans things up a bit and adds support for displaying backups from the old PGBackups system after we migrate them.

/cc @neovintage (N.B.: the backup naming scheme here is one suggested by pvh: just prefix anything coming from PGBackups with o--I can easily change this to something else that follows the same general mechanism)

[neovintage]

+1

On Tue, Apr 7, 2015 at 11:40 PM, Maciek Sakrejda [email protected]
wrote:

This cleans things up a bit and adds support for displaying backups from
the old PGBackups system after we migrate them.

/cc @neovintage https://github.com/neovintage (N.B.: the backup naming
scheme here is one suggested by pvh: just prefix anything coming from
PGBackups with o--I can easily change this to something else that follows

the same general mechanism)

You can view, comment on, or merge this pull request online at:

#1490
Commit Summary

• Show old pgbackups transfer names
• Better transfer_name function; use it more consistently
• Cleaner support for PGBackups backups

File Changes

• M lib/heroku/command/pg_backups.rb
  https://github.com/heroku/heroku/pull/1490/files#diff-0 (86)
• M spec/heroku/command/pg_backups_spec.rb
  https://github.com/heroku/heroku/pull/1490/files#diff-1 (36)

Patch Links:

• https://github.com/heroku/heroku/pull/1490.patch
• https://github.com/heroku/heroku/pull/1490.diff

—
Reply to this email directly or view it on GitHub
#1490.

[hgmnz]

Oh yes, +1!

[msakrejda]

Thanks!

[hgmnz]

woot, thanks @dickeyxxx

[neovintage]

thanks @dickeyxxx !

On Wed, Apr 8, 2015 at 4:41 PM, Harold Giménez [email protected]
wrote:

woot, thanks @dickeyxxx https://github.com/dickeyxxx

—
Reply to this email directly or view it on GitHub
#1490 (comment).