use v4 for auth:whoami

[jdx]

No description provided.

[mikehale]

I think this is doing the wrong thing. We should not run whoami we should lookup the logged in user based on what is in ~/.netrc.

[jdx]

why?

[mikehale]

That's what it used to do no?

[jdx]

it did, but that seems wrong to me. The login field in netrc could be anything, it wouldn't necessarily match to the HEROKU_API_KEY and it might have an expired token. This ticket mentions some of the issues with the old functionality: #1149

[mikehale]

If I wanted to see my local machine user I'd just do echo $USER or whoami. If I want to see who I am on heroku I run heroku auth:whoami.

... just tried this locally and I'm definitely getting back my heroku user. I guess I was thinking that these were equivalent, but it seems to be doing something else which I don't understand:

Heroku::JSPlugin.run('whoami', nil, ARGV[1..-1])

and

whoami

[jdx]

oh so when I do Heroku::JSPlugin.run('whoami', nil, ARGV[1..-1]) what that does is call heroku whoami on the v4 cli at ~/.heroku/heroku-cli. Note that I changed this after the PR to be ~/.heroku/heroku-cli auth:whoami

[jdx]

but yeah, the new functionality calls /account on the api and returns the email there. This way should be better for scripting though because it's not just reading the .netrc file, it's actually checking to see if you will be able to access the API

[jdx]

some users were surprised that even though heroku auth:whoami returned an email that didn't mean they could actually use the API

[mikehale]

Ah, that makes sense.