Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Always display unjoined org apps #1692

Merged
merged 1 commit into from
Aug 18, 2015
Merged

Conversation

ryanbrainard
Copy link
Contributor

Note, the base for this PR is space-apps-unjoined for a clearer diff of the what's changing and to avoid a future merge conflict; however, it should be merged all the way to master.

This changes the org app list to always display joined and unjoined apps together in one list for parity with Dashboard. Hiding and segregating unjoined apps has proved to confuse users.

This leaves the --all option in place, but updates the documentation to reflect what is actually does for the personal app list.

/cc @naaman @dickeyxxx

This changes the org app list to always display joined and unjoined apps together in one list for parity with Dashboard. Hiding and segregating unjoined apps has proved to confuse users.

This leaves the --all option in place, but updates the documentation to reflect what is actually does for the personal app list.
@naaman
Copy link

naaman commented Aug 18, 2015

Seems like we should just get rid of --all; it's more confusing with this change than helpful. I'm not sure why we'd filter out org apps at this point.

Aside from introducing a UX issue, 👍.

@ryanbrainard
Copy link
Contributor Author

@naaman I went back and forth on that, but decided to leave it because 1) it makes it act like the personal app list on Dashboard, 2) it scopes the change to the org app list only, 3) does not break scripts that use the flag today. If we do completely remove --all, we would need to decide what the behavior would be for the personal app list. If we want to make it like Dashboard, the list would to be never include org apps (even joined apps) in the personal app list.

jdx pushed a commit that referenced this pull request Aug 18, 2015
Always display unjoined org apps
@jdx jdx merged commit 681f0fd into space-apps-unjoined Aug 18, 2015
@jdx jdx deleted the org-apps-all-always branch August 18, 2015 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants