Expose store.toml contents in BuildContext
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/store-toml
branch
from
881585f to
298755b
Compare
Malax
force-pushed
the
malax/store-toml
branch
from
298755b to
d9da442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, it wasn't possible to access to contents of
store.tomlvia libcnb. This PR adds a minimal implementation and tests for accessing that data. I deliberately limited this PR to just that and not address issues withstore.tomlhandling in general:store.tomlshould be typed like layer metadata is. Working with raw TOML with Rust is tedious, especially when we need a specific TOML type (store.toml metadata needs to be atoml::value::Table. However, this is not just a matter of slapping a new associated type onBuildpackand use that to parse the metadata. We need a mechanism to handle incompatibilities (like we do with layer metadata). (I filed: Typedstore.tomlmetadata #544)BuildResultdoes not containstore.tomldata (i.e. that field isNone), the file on disk is not modified. This is inconsistent with i.e. layers where the metadata needs to be written every time to keep it around. There is currently no way to remove all metadata either sinceNonesignals "don't change" instead of "no data". (I filed: Inconsistent handling ofstore.toml#545)Without the fixes for the issues above, this PR a non breaking change we can roll out immediately as a point release to provide the needed functionality to buildpacks that need it and tackle the harder breaking changes separately.
Closes GUS-W-12299144