Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experinemtal parser generates inconsistent operation enum naming #1315

Closed
mariusch opened this issue Nov 20, 2024 · 1 comment · Fixed by #1326
Closed

Experinemtal parser generates inconsistent operation enum naming #1315

mariusch opened this issue Nov 20, 2024 · 1 comment · Fixed by #1326
Labels
bug 🔥 Something isn't working prioritized 🚚 This issue has been prioritized and will be worked on soon
Milestone

Comments

@mariusch
Copy link

Description

Description

The experimental OpenAPI parser is generating inconsistent naming patterns for operation enums compared to the previous parser.

Previous:
export const Operation = { EQUALS: "Equals", NOT_EQUALS: "NotEquals", IN: "In", NOT_IN: "NotIn", GREATER_THEN: "GreaterThen", LESS_THAN: "LessThan", BETWEEN: "Between", EMPTY: "Empty", NOT_EMPTY: "NotEmpty", NONE: "None", } as const;

Current:
export const Operation = { EQUALS: "Equals", NOTEQUALS: "NotEquals", IN: "In", NOTIN: "NotIn", GREATERTHEN: "GreaterThen", LESSTHAN: "LessThan", BETWEEN: "Between", EMPTY: "Empty", NOTEMPTY: "NotEmpty", NONE: "None", } as const;

This breaks existing code that references these enum values and introduces inconsistency in the naming convention.

Expected Behavior

Operation enum values should maintain consistent underscore-separated naming (e.g., NOT_EQUALS) as in the previous parser.

Current Behavior

Operation enum values are generated without underscores (e.g., NOTEQUALS), breaking existing code references.

Reproducible example or configuration

No response

OpenAPI specification (optional)

No response

System information (optional)

No response

@mariusch mariusch added the bug 🔥 Something isn't working label Nov 20, 2024
@mrlubos mrlubos added this to the Parser milestone Nov 20, 2024
@mrlubos mrlubos added the prioritized 🚚 This issue has been prioritized and will be worked on soon label Nov 20, 2024
@mrlubos
Copy link
Member

mrlubos commented Nov 20, 2024

Yep! #1244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🔥 Something isn't working prioritized 🚚 This issue has been prioritized and will be worked on soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants