Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve generated enum keys in experimental parser #1326

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Nov 22, 2024

Closes #1244
Closes #1315

Copy link

stackblitz bot commented Nov 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review November 22, 2024 09:53
Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: 01c3d69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 9:58am

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 65.13%. Comparing base (8976ccd) to head (01c3d69).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...enapi-ts/src/plugins/@hey-api/typescript/plugin.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
+ Coverage   65.12%   65.13%   +0.01%     
==========================================
  Files         137      137              
  Lines       21131    21126       -5     
  Branches     1825     1825              
==========================================
- Hits        13762    13761       -1     
+ Misses       7365     7361       -4     
  Partials        4        4              
Flag Coverage Δ
unittests 65.13% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mrlubos mrlubos merged commit a9cca25 into main Nov 22, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/experimental-parser-enum-names branch November 22, 2024 10:05
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experinemtal parser generates inconsistent operation enum naming Improve enum key names
1 participant