Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transformers handle allOf composition in experimental parser #1382

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 4, 2024

Closes #1259

Copy link

stackblitz bot commented Dec 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: b358e23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 6:43am

@mrlubos mrlubos marked this pull request as ready for review December 4, 2024 06:42
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 72 lines in your changes missing coverage. Please review.

Project coverage is 65.12%. Comparing base (7ae5eb1) to head (b358e23).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...api-ts/src/plugins/@hey-api/transformers/plugin.ts 4.25% 45 Missing ⚠️
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 0.00% 20 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 65.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   65.24%   65.12%   -0.12%     
==========================================
  Files         140      140              
  Lines       21632    21684      +52     
  Branches     1863     1865       +2     
==========================================
+ Hits        14113    14122       +9     
- Misses       7515     7558      +43     
  Partials        4        4              
Flag Coverage Δ
unittests 65.12% <18.18%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 20aa8aa into main Dec 4, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/transformers-experimental-drift branch December 4, 2024 06:53
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[experimentalParser] Transformers warning: ... is too complex and won't be currently processed
1 participant