Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zod plugin handles recursive schemas #1416

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 11, 2024

Closes #1393

Copy link

stackblitz bot commented Dec 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 2a605b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:16pm

@mrlubos mrlubos marked this pull request as ready for review December 11, 2024 14:03
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 7.36842% with 88 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (318e06e) to head (2a605b7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/zod/plugin.ts 6.38% 88 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1416      +/-   ##
==========================================
- Coverage   64.08%   63.89%   -0.20%     
==========================================
  Files         141      141              
  Lines       21957    22033      +76     
  Branches     1843     1843              
==========================================
+ Hits        14072    14078       +6     
- Misses       7879     7949      +70     
  Partials        6        6              
Flag Coverage Δ
unittests 63.89% <7.36%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos force-pushed the fix/zod-plugin-circular-ref branch from ac09df8 to 2a605b7 Compare December 11, 2024 16:15
@mrlubos mrlubos merged commit 322eccb into main Dec 11, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/zod-plugin-circular-ref branch December 11, 2024 16:24
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zod plugin cannot handle self referenced schemas
1 participant