Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send GET request only on first spec fetch #1543

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jan 9, 2025

Closes #1532

Copy link

stackblitz bot commented Jan 9, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 7a2d6dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review January 9, 2025 16:40
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 4:40pm

const eTag = response.headers.get('ETag');
if (eTag) {
hasChanged = eTag !== watch.headers.get('If-None-Match');
if (hasChanged === undefined) {

Check notice

Code scanning / CodeQL

Unneeded defensive code Note

This guard always evaluates to true.
Copy link

pkg-pr-new bot commented Jan 9, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@hey-api/client-axios@1543
npm i https://pkg.pr.new/@hey-api/openapi-ts@1543
npm i https://pkg.pr.new/@hey-api/client-fetch@1543

commit: 7a2d6dc

@mrlubos mrlubos merged commit 874934d into main Jan 9, 2025
12 checks passed
@mrlubos mrlubos deleted the fix/fetch-spec-first-request branch January 9, 2025 16:47
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 16.98113% with 44 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (caa46ec) to head (7a2d6dc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/index.ts 16.98% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
- Coverage   59.30%   59.20%   -0.10%     
==========================================
  Files         158      158              
  Lines       24748    24750       +2     
  Branches     1892     1888       -4     
==========================================
- Hits        14676    14653      -23     
- Misses      10065    10090      +25     
  Partials        7        7              
Flag Coverage Δ
unittests 59.20% <16.98%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP ERROR 404 when generating client using HTTPS URL
1 participant