Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zod plugin coerces bigint #1552

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix: zod plugin coerces bigint #1552

merged 1 commit into from
Jan 12, 2025

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Jan 12, 2025

No description provided.

Copy link

stackblitz bot commented Jan 12, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jan 12, 2025

🦋 Changeset detected

Latest commit: ceb8bd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review January 12, 2025 21:36
Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 9:37pm

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 59.19%. Comparing base (a22d34f) to head (ceb8bd7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/openapi-ts/src/plugins/zod/plugin.ts 7.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
- Coverage   59.20%   59.19%   -0.02%     
==========================================
  Files         158      158              
  Lines       24750    24757       +7     
  Branches     1888     1888              
==========================================
+ Hits        14653    14654       +1     
- Misses      10090    10096       +6     
  Partials        7        7              
Flag Coverage Δ
unittests 59.19% <7.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-axios@1552
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@1552
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/client-fetch@1552

commit: ceb8bd7

@mrlubos mrlubos merged commit 9c9e9c5 into main Jan 12, 2025
15 of 17 checks passed
@mrlubos mrlubos deleted the fix/zod-bigint-coerce branch January 12, 2025 21:45
@github-actions github-actions bot mentioned this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant